RFR: JDK-8288993: Make AwtFramePackTest generic by removing @requires tag

Sergey Bylokhov serb at openjdk.org
Thu Jun 23 06:09:43 UTC 2022


On Wed, 22 Jun 2022 18:50:49 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> The following test was changed to generic based on this [Review Comment](https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/9118*discussion_r897553780__;Iw!!ACWV5N9M2RV99hQ!P_GL_NjJc6mQksISE_S4ESnbESYQ3p0UToATIN3T-tcXlKTRrjPp9Zv_4daRhzlJmEbbS_AftmcQrfKhNwSpDA$ ) and as the condition `frame.getSize() == frame.getPreferredSize() ` should hold on all platforms when frame.pack() is used.

test/jdk/java/awt/Frame/AwtFramePackTest.java line 44:

> 42:  * @summary Tests whether insets are calculated correctly on Windows
> 43:  * for AWT Frame by checking the actual and expected/preferred frame sizes.
> 44:  * @run main/othervm -Dsun.java2d.uiScale=1 AwtFramePackTest

Please double check that the "-Dsun.java2d.uiScale=1" option is needed here, It does not affect the frame decoration, and I think this can cause the test to fail if the desktop scale=200% is set in the WIndows.

-------------

PR: https://git.openjdk.org/jdk/pull/9248



More information about the client-libs-dev mailing list