RFR: 8267374: (macos) Left Option+Up/Down arrow dont traverse to beginning/end of line in textarea [v5]

[Prasanta Sadhukhan]

On Fri, 24 Jun 2022 17:52:18 GMT, Phil Race <prr at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix Right Option Key handling
>
> src/java.desktop/macosx/classes/com/apple/laf/AquaKeyBindings.java line 95:
> 
>> 93:         "alt altgraph LEFT", DefaultEditorKit.previousWordAction,
>> 94:         "alt altgraph RIGHT", DefaultEditorKit.nextWordAction,
>> 95:         "alt UP", DefaultEditorKit.beginLineUpAction,
> 
> I find it utterly bizarre to say we need "altgraph" when macOS doesn't have altgraph - certainly not on the k/bs on current mac books or imacs.
> 
> My take is that the previous fix JDK-8151136 was a mistake and we should have just excluded the test there on macOS.

I also agree.

> src/java.desktop/share/classes/javax/swing/text/DefaultEditorKit.java line 650:
> 
>> 648:      * upward one line otherwise.
>> 649:      * @see #getActions
>> 650:      */
> 
> What ? We are adding new public API to solve this ? 
> Why is that necessary ?

Not public API..we are adding new editor "actions" if we need to keep previous fix..Without the previous fix JDK-8151136 , it works and we will not need to add these new actions.

-------------

PR: https://git.openjdk.org/jdk/pull/9230