RFR: 8288444: Remove the workaround for frame.pack() in ModalDialogTest

[Harshitha Onkar]

On Fri, 24 Jun 2022 22:12:35 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> Previously frame.pack() was called twice as a workaround  AWT frame sizing issue in this particular test case on Windows. This issue was fixed **[JDK-8265586](https://bugs.openjdk.org/browse/JDK-8265586)** and hence the workaround is being removed from this test.
> 
> PassFailJFrame is being used as the test framework. 
> 
> **Proposed change related to PassFailJFrame Test framework**
> 
> Instead of creating separate methods to handle AWT Windows as well as Frames, method signatures - [**PassFailJFrame.positionTestFrame()**](https://urldefense.com/v3/__https://github.com/openjdk/jdk/blob/53b37fe1535388eb14e04c620a6b0118ed8884a0/test/jdk/java/awt/regtesthelpers/PassFailJFrame.java*L271__;Iw!!ACWV5N9M2RV99hQ!O_tc71pCH8M_I8Ag28EQQ6aYJOFaEVGpuhafqNBZmr6G1mobn57dnkRIOY-RZ-tZccq7FhnMayruH-3alhdIk_q5$ ) and [**PassFailJFrame.addTestFrame()**](https://urldefense.com/v3/__https://github.com/openjdk/jdk/blob/53b37fe1535388eb14e04c620a6b0118ed8884a0/test/jdk/java/awt/regtesthelpers/PassFailJFrame.java*L294__;Iw!!ACWV5N9M2RV99hQ!O_tc71pCH8M_I8Ag28EQQ6aYJOFaEVGpuhafqNBZmr6G1mobn57dnkRIOY-RZ-tZccq7FhnMayruH-3all_VbfvZ$ ) can be changed to take in Window as input parameter instead of Frame, since Window is a superclass, this would allow the test frame to be a Window/Frame/Dialog and not be restricted to a Frame, additionally would allow proper disposal of windows added to the PassFailJFrame.

The proposed changes for PassFailJFrame are being tracked through: [JDK-8289238](https://bugs.openjdk.org/browse/JDK-8289238)

-------------

PR: https://git.openjdk.org/jdk/pull/9286