RFR: JDK-8289238: Refactoring changes to PassFailJFrame Test Framework [v2]
Harshitha Onkar
honkar at openjdk.org
Tue Jun 28 20:30:36 UTC 2022
> Currently PassFailJFrame.positionTestFrame() and PassFailJFrame.addTestFrame() take Frame as input parameter, this has been changed to Window.
>
> Refactored the above method names to reflect the functionality & input parameter type -
> addTestWindow(), positionTestWindow()
>
> Additionally added test fail reason to `forceFail()` to avoid NPE.
>
> Benefits of the change -
>
> - Since Window is a parent class, this would allow the test frame to be a Window/Frame/Dialog and not be restricted to a Frame.
> - Code reusability - no need to have separate methods to manage Frame and Window
> - Additionally it would allow proper clean-up of window and its container subclasses which are added to the PassFailJFrame.
Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
method doc changes
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/9300/files
- new: https://git.openjdk.org/jdk/pull/9300/files/ef00a014..30d379ab
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=9300&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=9300&range=00-01
Stats: 9 lines in 1 file changed: 2 ins; 0 del; 7 mod
Patch: https://git.openjdk.org/jdk/pull/9300.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/9300/head:pull/9300
PR: https://git.openjdk.org/jdk/pull/9300
More information about the client-libs-dev
mailing list