Integrated: JDK-8289238: Refactoring changes to PassFailJFrame Test Framework

Harshitha Onkar honkar at openjdk.org
Wed Jun 29 18:39:42 UTC 2022


On Tue, 28 Jun 2022 00:58:42 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> Currently PassFailJFrame.positionTestFrame() and PassFailJFrame.addTestFrame() take Frame as input parameter, this has been changed to Window.
> 
> Refactored the above method names to reflect the functionality & input parameter type -
> addTestWindow(), positionTestWindow()
> 
> Additionally added test fail reason to `forceFail()` to avoid NPE.
> 
> Benefits of the change -
> 
> - Since Window is a parent class, this would allow the test frame to be a Window/Frame/Dialog and not be restricted to a Frame.
> - Code reusability - no need to have separate methods to manage Frame and Window
> - Additionally it would allow proper clean-up of window and its container subclasses which are added to the PassFailJFrame.

This pull request has now been integrated.

Changeset: 15efb2bd
Author:    Harshitha Onkar <honkar at openjdk.org>
Committer: Alexey Ivanov <aivanov at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/15efb2bdeb73e4e255dcc864be1a83450a2beaa8
Stats:     43 lines in 8 files changed: 3 ins; 2 del; 38 mod

8289238: Refactoring changes to PassFailJFrame Test Framework

Reviewed-by: azvegint, aivanov

-------------

PR: https://git.openjdk.org/jdk/pull/9300



More information about the client-libs-dev mailing list