RFR: 8065097: [macosx] javax/swing/Popup/TaskbarPositionTest.java fails because Popup is one pixel off [v3]

[Alexey Ivanov]

On Thu, 30 Jun 2022 08:57:16 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Test seems to fail in macOS citing popup location is 1 pixel off compared to combobox position ie
>> `p.y 154 cpos.y 155`
>> 
>> But in macOS, popup location, if 1st entry is selected, is 1 pixel higher than combobox so it's expected as can be seen below
>> <img width="661" alt="Screenshot 2022-06-29 at 1 53 42 PM" src="https://user-images.githubusercontent.com/43534309/176389227-4e568117-ffce-4b4a-92d7-ab5c78c4ce08.png">
>> 
>> so test is updated to add 1 pixel to popup location. 
>> It will not affect windows and linux as popup is placed below the combobox in those platforms so 1 pixel higher will not make any difference.
>> Also, added some stability fixes..Test passed for several iterations in all platforms in CI..
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comments addressed

It looks good.

However, the test does not behave as it should on macOS.
Additionally, the position of combo box popups aren't verified (except for the last one).

Anyway, these other issues are out of scope of this one.

test/jdk/javax/swing/Popup/TaskbarPositionTest.java line 107:

> 105: 
> 106:         // Place the frame near the bottom.
> 107:         frame.setLocation(0, screenBounds.y + screenBounds.height - frame.getHeight());

This should be moved below, after the insets of the graphics device are taken into account.

-------------

Marked as reviewed by aivanov (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9321