RFR: 6911375: mouseWheel has no effect without vertical scrollbar [v2]

Alexey Ivanov aivanov at openjdk.java.net
Tue Mar 1 16:44:12 UTC 2022


On Mon, 28 Feb 2022 08:02:39 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> test/jdk/javax/swing/JScrollPane/TestMouseWheelScroll.java line 80:
>> 
>>> 78:                     scrollPane.setVerticalScrollBarPolicy(JScrollPane.VERTICAL_SCROLLBAR_NEVER);
>>> 79:                     frame.add(scrollPane);
>>> 80:                     frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
>> 
>> Suggestion:
>> 
>>                     frame.setDefaultCloseOperation(JFrame.DISPOSE_ON_CLOSE);
>> 
>> It's safer for tests.
>
> This testcase was failing on macos which needs to be debugged, so it is excluded in mac for now. But as I told in description, the fix is not affecting other regression test in macos.
> It's working on other platforms and I have some issue in my local mac system so I will take this debugging of macos once I sort my system.
> 
> Regarding your other question, the orientation will be horizontal. Tested against javax/swing/JScrollPane/HorizontalMouseWheelOnShiftPressed/HorizontalMouseWheelOnShiftPressed.java

I see, thank you for explanation. Does it make sense to put the test in ProblemList.txt for macOS, so that it's not forgotten the test is to be run on macOS too?

-------------

PR: https://git.openjdk.java.net/jdk/pull/7585



More information about the client-libs-dev mailing list