RFR: 8282577: ICC_Profile.setTagData() invalidates the profile [v2]

Phil Race prr at openjdk.java.net
Thu Mar 3 20:59:45 UTC 2022


> As per the bug eval, we are returning a pointer to a native raw LittleCMS profile and it should be a cooked one.
> The simple test fails before the fix with
> ~/jdk17/Contents/Home/bin/java SetTagDataValidation                               
> Exception in thread "main" java.awt.color.CMMException: LCMS error 13: Couldn't link the profiles
> 	at java.desktop/sun.java2d.cmm.lcms.LCMS.createNativeTransform(Native Method)
> 	at java.desktop/sun.java2d.cmm.lcms.LCMS.createTransform(LCMS.java:104)
> 	at java.desktop/sun.java2d.cmm.lcms.LCMSTransform.doTransform(LCMSTransform.java:143)
> 	at java.desktop/sun.java2d.cmm.lcms.LCMSTransform.colorConvert(LCMSTransform.java:633)
> 	at java.desktop/java.awt.color.ICC_ColorSpace.toRGB(ICC_ColorSpace.java:224)
> 	at SetTagDataValidation.main(SetTagDataValidation.java:61)
> 
> and with the fix  just prints 
> java SetTagDataValidation
> 0.4
> 0.5000076
> 0.6

Phil Race has updated the pull request incrementally with one additional commit since the last revision:

  8282577: ICC_Profile.setTagData() invalidates the profile

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/7668/files
  - new: https://git.openjdk.java.net/jdk/pull/7668/files/e46c65c1..2ecf8211

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7668&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7668&range=00-01

  Stats: 7 lines in 2 files changed: 6 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7668.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7668/head:pull/7668

PR: https://git.openjdk.java.net/jdk/pull/7668



More information about the client-libs-dev mailing list