RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v2]

Phil Race prr at openjdk.java.net
Fri Mar 4 21:35:17 UTC 2022


On Fri, 4 Mar 2022 00:49:39 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Changed the drawing area to be increased by 0.5 on the left side to prevent clipping
>
> Alisen Chung has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - adjusted pixels to check for border
>  - typo
>  - reverted old change, swapped order of painting to prevent overdrawing

Can you explain (walk through) why the old code was wrong and the new code is correct ?
There's a lot of things that aren't obvious to me.
The old code would use the same coords and just toggle which parts were in highlight/shadow
Now you've spilit is so that lowered does things in a different order and so forth and I find it
impossible without an explanation of your reasoning to say if that reasoning is correct ...

Also the bug report deserves an evaluation.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7449



More information about the client-libs-dev mailing list