RFR: 8275715: D3D pipeline processes multiple PaintEvent at initial drawing [v2]

Phil Race prr at openjdk.java.net
Mon Mar 7 02:30:09 UTC 2022


On Thu, 28 Oct 2021 08:27:44 GMT, Masanori Yano <myano at openjdk.org> wrote:

>> Could you please review the 8275715 bug fixes?
>> 
>> I think D3DScreenUpdateManager posts unnecessary PaintEvent during processing PaintEvent. When the validate method is called from createGraphics, repaintPeerTarget should not be called.
>
> Masanori Yano has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8275715: D3D pipeline processes multiple PaintEvent at initial drawing

FWIW this should not have been pushed without a 2nd reviewer (meaning two approvals). 
Please review the code review policies section here  https://openjdk.java.net/groups/client-libs/
where it says 
The standard requirement in Java SE is for one (or more) reviewer prior to code freeze and two (or more) reviewers thereafter. The Java Client Library Group has standardized on two reviewers with few exceptions.

You pushed with only one approval. Bear that in mind !

-------------

PR: https://git.openjdk.java.net/jdk/pull/6064



More information about the client-libs-dev mailing list