RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage
Alexey Ivanov
aivanov at openjdk.java.net
Thu Mar 10 16:02:46 UTC 2022
On Thu, 10 Mar 2022 15:30:51 GMT, Tejesh R <duke at openjdk.java.net> wrote:
>> That was my concern too. In fact, `InterruptedException` is not in the regular flow, it indicates a somewhat error condition which isn't actually handled.
>>
>> If `loadStatus` of the image is not `COMPLETE` or `ERRORED`, we should probably move it to `ABORTED`.
>>
>> I don't think we should raise Thread.interrupt flag again.
>
> WaitForID() definition states that "If there is an error while loading or scaling an image, then that image is considered to have finished loading". Does this indicates that no error checking is required.....?
But in this case it's the waiting thread that is interrupted. The `MediaTracker` could complete loading the image successfully yet `ImageIcon` instance wouldn't update its `loadStatus` because it removes itself from the media tracker.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7754
More information about the client-libs-dev
mailing list