RFR: 7124282: [macosx] Can't see table cell highlighter when the highlight border is the same color as the cell. [v3]

Prasanta Sadhukhan psadhukhan at openjdk.java.net
Wed Mar 16 07:36:37 UTC 2022


On Mon, 14 Mar 2022 22:27:37 GMT, Harshitha Onkar <duke at openjdk.java.net> wrote:

>> @prsadhuk Thank you for reviewing. 
>> 
>> Earlier when I used the default thickness (thickness=1) the cell focus ring was visible but not prominent as shown in the following screenshot. Please let me know if I need to change thickness to 1 or keep it the same?
>> 
>> **Thickness=1**
>> 
>> ![image](https://user-images.githubusercontent.com/95945681/158270171-8260c71f-511f-481e-b88e-f226818a8219.png)
>> 
>> The thickness looks the same on retina as well as non-retina display. I have included the screenshots for comparison-
>> 
>> ![image](https://user-images.githubusercontent.com/95945681/158270568-b3018b09-8227-4bf0-9751-80d30df4e411.png)
>
> Since List.focusCellHighlightBorder uses the same focusRingColor as used by Table we can change it for List as well. Can I make changes to List using this issue and PR or should I track it by adding a new JBS bug/PR ?

Just thinking,  Do we need to manipulate hue and saturation for focus ring?
It seems from native "Numbers" app which is closest to Tables & cells, I see the focus ring is always blue irrespective of what the selection background (and system accent color) is
and since Aqua should mimic native look, so I guess just this change will probably do
 ```
- Table.focusCellHighlightBorder", focusCellHighlightBorder,
 + Table.focusCellHighlightBorder", new BorderUIResouce.LineBorderUIResouce(Color.blue), 2),

-------------

PR: https://git.openjdk.java.net/jdk/pull/7768



More information about the client-libs-dev mailing list