RFR: 8276849: Refresh the window icon on graphics configuration changes [v4]

Alexey Ivanov aivanov at openjdk.java.net
Wed Mar 16 20:43:47 UTC 2022


On Wed, 23 Feb 2022 21:34:29 GMT, Emmanuel Bourg <duke at openjdk.java.net> wrote:

>> Emmanuel Bourg has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Test case for the window icon update on DPI change (Java generic font names are usually capitalized)
>>  - Test case for the window icon update on DPI change (dispose the frame after a timeout on the EDT)
>
> Just tested on macOS 12 with a non Retina screen and OpenJDK 8: the icon displayed in the dock when the test frame is minimized is the 32x32 one. If I add more icons to the list, it picks the biggest one, up to 128x128. Bigger icons are ignored.
> 
> The issue observed on Windows doesn't really transpose to macOS, I think I'll revert the change to `LWWindowPeer`.

@ebourg  How did you test on Linux? No icon is displayed in the title bar of the window on Linux Mint and on Ubuntu Linux.

For me, the icon on the taskbar always remains 32, it doesn't look sharp. In the system settings, the size of the icon is set to 48. The icon didn't refresh when I changed the size of the taskbar icon.

At the same time, the icon on the taskbar did animate as if changed when I moved the window from one monitor to another.

Does the set of icons in the test need to be increased to 48? Could it be the reason why on macOS dock the icon doesn't change? I mean there's no a higher resolution icon available.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6180



More information about the client-libs-dev mailing list