RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage [v2]

Tejesh R duke at openjdk.java.net
Tue Mar 22 12:51:36 UTC 2022


On Tue, 22 Mar 2022 11:30:13 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updated based on review comments
>
> src/java.desktop/share/classes/javax/swing/ImageIcon.java line 341:
> 
>> 339:             {
>> 340:                 loadStatus = MediaTracker.ABORTED;
>> 341:             }
> 
> Did you compile this code?  
> I can't see `interrupted` variable being declared.
> 
> Please follow Java Coding Style: a space between `if` and the opening parenthesis, the opening brace is on the same line rather than on its own line. The code that [I posted as a sample](https://github.com/openjdk/jdk/pull/7754#discussion_r831096445) follows the Java Style.

Previous code I compiled and tested, the one I committed was not compiled and tested yet, had to commit coz I'm restoring my local repo, after restoring will make the changes and test locally and with mach5......

-------------

PR: https://git.openjdk.java.net/jdk/pull/7754



More information about the client-libs-dev mailing list