RFR: JDK-8282046: Create a regression test for JDK-8000326 [v6]

Alexey Ivanov aivanov at openjdk.java.net
Wed Mar 23 10:16:38 UTC 2022


On Wed, 23 Mar 2022 06:19:14 GMT, Srinivas Mandalika <smandalika at openjdk.org> wrote:

>> Create a regression test for CCC8000326
>> 
>> Issue is identified by [JDK-8000326](https://bugs.openjdk.java.net/browse/JDK-8000326), which identifies that after focus moves into JMenuBar, whose focus traversal key is disabled by default, it never moves to other focusable component.
>>  
>> By default, pressing the Tab key does not transfer focus from a JMenuBar which is added to a container together with other Swing components, because the focusTraversalKeysEnabled property of JMenuBar is set to false. To resolve this, you should call the JMenuBar.setFocusTraversalKeysEnabled(true) method.
>>  
>> The test verifies focus traversal for the above described scenario.
>> This review is for migrating tests from a closed test suite to open.
>
> Srinivas Mandalika has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comments fixed: Copyright header fixed with original year of test authorship

Changes requested by aivanov (Reviewer).

test/jdk/java/awt/Focus/8000326/SetFocusTraversalKeysEnabledTest.java line 2:

> 1: /*
> 2:  * Copyright (c) 2013,2022, Oracle and/or its affiliates. All rights reserved.

Suggestion:

 * Copyright (c) 2013, 2022, Oracle and/or its affiliates. All rights reserved.

There has to be space after the comma.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7512



More information about the client-libs-dev mailing list