RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage [v5]

Tejesh R duke at openjdk.java.net
Fri Mar 25 10:05:57 UTC 2022


On Wed, 23 Mar 2022 18:18:57 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updated based on review comments
>
> It looks good now.
> 
> Is it possible to add a regression test? We have one now, don't we? It just needs to be done as a jtreg automated test which verifies the status is any of the _done_ statuses, not `LOADING`.
> 
> A more complicated test could also verify the printed message is gone.

Sure @aivanov-jdk , will add regression test......

-------------

PR: https://git.openjdk.java.net/jdk/pull/7754



More information about the client-libs-dev mailing list