RFR: 8024624: [TEST_BUG] [macosx] CTRL+RIGHT(LEFT) doesn't move selection on next cell in JTable on Aqua L&F [v2]

DamonGuy duke at openjdk.java.net
Fri Mar 25 19:20:43 UTC 2022


> Aqua L&F tables lacked support for `CTRL+ARROW`, `CTRL+PG_UP/DOWN`, and `CTRL+SHIFT+PG_UP/DOWN` key bindings. This allows for navigation and selection of table cells without the need of a mouse and without deselecting the current selected cell group. 
> 
> Those key bindings are added to Aqua's key bindings for tables. The `SPACE` key binding was also added because it allows for the selection of cells after navigating using the `CTRL+ARROW` bindings, and some of the new bindings are only useful with the `SPACE` binding added. The closed test that this bug originates from tests for both left-to-right and right-to-left functionality, so the new directional bindings are also added to the right-to-left key bindings table where needed.
> 
> This requires mission control shortcuts in macOS to be disabled as `CTRL+ARROW` keys are normally used for virtual desktop navigation.

DamonGuy has updated the pull request incrementally with one additional commit since the last revision:

  Converted closed repo test to open repo. Removed changes to Aqua key bindings.

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/7792/files
  - new: https://git.openjdk.java.net/jdk/pull/7792/files/e5ce124e..b2492f21

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7792&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7792&range=00-01

  Stats: 329 lines in 2 files changed: 295 ins; 27 del; 7 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7792.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7792/head:pull/7792

PR: https://git.openjdk.java.net/jdk/pull/7792



More information about the client-libs-dev mailing list