RFR: 8283712 : Create a manual test framework class [v3]
lawrence.andrews
duke at openjdk.java.net
Mon Mar 28 17:06:42 UTC 2022
On Sat, 26 Mar 2022 02:37:09 GMT, Phil Race <prr at openjdk.org> wrote:
>> lawrence.andrews has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fixed the white space issue
>
> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 103:
>
>> 101: * If user does not select pass or fail button then the test waits for
>> 102: * the specified timeoutMinutes period and the test gets timeout.
>> 103: * This method should not be invoke with in EDT.
>
> This method should not be invoked on the EDT ?
>
> Actually I wonder if we can do better for this AND the other method.
>
> CHECK if its the EDT and if it is invoke dispose() directly, if it isn't then use invokeAndWait.
>
> Also remember that SwingUtilities.invokeAndWait is just a wrapper for EventQueue.invokeAndWait
Fixed as suggested.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7966
More information about the client-libs-dev
mailing list