RFR: 8274082 : Wrong test case name specified in jtreg run tag for java/awt/print/PrinterJob/SwingUIText.java

Alexandre Iline shurailine at openjdk.java.net
Tue Mar 29 21:33:48 UTC 2022


On Thu, 24 Mar 2022 20:24:35 GMT, lawrence.andrews <duke at openjdk.java.net> wrote:

> Following issues were fixed in this test 
> 1) Fixed - Parser error due to yesno in @run main/manual=yesno
> 2) Fixed Wrong test name specified in @run jtreg
> @run main/manual=yesno PrintTextTest . It should be @run main/manual=yesno SwingUIText
> 3) Instruction frame does not have 'Pass' or 'Fail' button to mark the test as Pass or Fail after verifying Text on UI and print out. 
> 4) Fixed - Test UI ( test instruction frame, UI frame and Print Dialog) just gets disposed automatically without interacting via running the test case with jtreg. 
> 
> @shurymury

test/jdk/java/awt/print/PrinterJob/SwingUIText.java line 96:

> 94:     private static void createTestInstructionUI() {
> 95:         testInstructionFrame = new JFrame("Test Instruction Frame");
> 96:         final String INSTRUCTION = """

Would this make more sense to use the already existing manual test support from the A11Y tests?

test/jdk/java/awt/print/PrinterJob/SwingUIText.java line 101:

> 99:                 as seen on-screen, and that the spacing of the text is of,
> 100:                 reasonable even-ness. This latter part is very subjective and,
> 101:                 the comparison has to be with JDK1.5 GA, or JDK 1.6 GA.

Are test executors really to compare to JDK 1.5? Would it be possible to come up with a comprehensive criteria of some kind? Worst case, can some reference images be used for the test executor to compare the printout to?

-------------

PR: https://git.openjdk.java.net/jdk/pull/7946



More information about the client-libs-dev mailing list