RFR: 8283623: Create an automated regression test for JDK-4525475 [v2]

Manukumar V S mvs at openjdk.java.net
Wed Mar 30 10:45:26 UTC 2022


> Write a regression test for [JDK-4525475](https://bugs.openjdk.java.net/browse/JDK-4525475)
> 
> Issue:
> JFileChooser allows modification to the file-system by way of the "New Folder"
> button, and the ability to rename file/folder names. There is no method on
> JFileChooser which indicates that this type of modification should not be
> allowed within the given JFileChooser.
> 
> Testing:
> 1. Tested using Mach5(20 times per platform) in macos,linux and windows and got all pass.
> 2. Tested in original failed Java version and the fixed version;
> Java 1.4.0 -> Test Failed.
> $ j2sdk1.4.0/bin/java Bug4525475
> LookAndFeel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
> Name = Go Up, readOnly = true
> Name = New Folder, readOnly = true
> Its a Read Only JFileChooser and has a New Folder Button. So Test Failed.
> Name = Go Up, readOnly = false
> Name = New Folder, readOnly = false
> Failed
> 
> Java 1.5.0 -> Test Passed.
> $ jdk1.5.0/bin/java Bug4525475
> LookAndFeel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
> Name = Go Up, readOnly = true
> Name = Go Up, readOnly = false
> Name = New Folder, readOnly = false
> Passed

Manukumar V S has updated the pull request incrementally with one additional commit since the last revision:

  Review comments fixed: code for the Swing lib executed on EDT

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/7969/files
  - new: https://git.openjdk.java.net/jdk/pull/7969/files/1880311e..ba85beed

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7969&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7969&range=00-01

  Stats: 11 lines in 1 file changed: 5 ins; 0 del; 6 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7969.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7969/head:pull/7969

PR: https://git.openjdk.java.net/jdk/pull/7969



More information about the client-libs-dev mailing list