RFR: 8284767: Create an automated test for JDK-4422535 [v2]

Srinivas Mandalika smandalika at openjdk.java.net
Mon May 2 05:52:41 UTC 2022


On Tue, 26 Apr 2022 09:28:28 GMT, Srinivas Mandalika <smandalika at openjdk.org> wrote:

>> Create an automated test for [JDK-4422535](https://bugs.openjdk.java.net/browse/JDK-4422535)
>> AccessibleValue implementation only accept Integers
>> The AccessibleValue implementations of the following components:
>> 
>> java.awt.Scrollbar
>> javax.swing.AbstractButton
>> javax.swing.JInternalFrame
>> javax.swing.JSplitPane
>> javax.swing.JScrollBar
>> javax.swing.JProgressBar
>> javax.swing.JSlider
>> 
>> require the argument to setCurrentAccessibleValue(Number) to be an Integer, else they completely ignore it - it returns a false indicating that the value has not been set by the return value, but they cannot know the reason for that).
>> 
>> The test verifies that for each of the above components, the AccessibleValue is set when it is set to a Number (Float, Double, long etc) and not just for an Integer.
>> 
>> his review is for migrating tests from a closed test suite to open.
>> 
>> Testing:
>> The test ran successfully on Mach5 with multiple runs (30) on windows-x64, linux-x64 and macos-x64.
>
> Srinivas Mandalika has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review Comments Fixed: Simplified test code with a loop over the JComponents being tested.

@alisenchung Can you please review the changes after incorporating the earlier feedback ?

-------------

PR: https://git.openjdk.java.net/jdk/pull/8220



More information about the client-libs-dev mailing list