RFR: 8282863: java/awt/FullScreen/FullscreenWindowProps/FullscreenWindowProps.java fails on Windows 10 with HiDPI screen [v2]

Dmitry Kulikov duke at openjdk.java.net
Wed May 4 08:03:28 UTC 2022


On Tue, 29 Mar 2022 11:03:37 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Dmitry Kulikov has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - 8282863: java/awt/FullScreen/FullscreenWindowProps/FullscreenWindowProps.java fails on Windows 10 with HiDPI screen
>>  - Revert "8282863: java/awt/FullScreen/FullscreenWindowProps/FullscreenWindowProps.java fails on Windows 10 with HiDPI screen"
>>    
>>    This reverts commit 23b40af8de9df4db9a1cc0137c0e875cf6595190.
>
> src/java.desktop/windows/classes/sun/awt/Win32GraphicsDevice.java line 447:
> 
>> 445: 
>> 446:     /**
>> 447:      * Reapplies the size of this device to the full-screen window.
> 
> What is _this device_? There's no device in the parameters of the method.
> 
> If you write javadoc, you should document the parameters too.

@aivanov-jdk I've updated the JavaDoc to more specifically reference the GraphicsDevice that owns the added method (and documented the parameters)

-------------

PR: https://git.openjdk.java.net/jdk/pull/7835



More information about the client-libs-dev mailing list