RFR: 8284888 : [macos] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java failed with "NimbusLookAndFeel] : ERROR: icon and imageIcon not same." [v2]
Prasanta Sadhukhan
psadhukhan at openjdk.java.net
Wed May 4 11:04:50 UTC 2022
> Test used to fail in specific CI macos M1 system owing to miniscule color difference
>
>
> x 0 y 0 red1 171 red2 171 green1 174 green2 175 blue1 184 blue2 184
> x 0 y 1 red1 172 red2 173 green1 177 green2 177 blue1 185 blue2 185
> x 0 y 2 red1 173 red2 174 green1 177 green2 178 blue1 187 blue2 187
> x 0 y 6 red1 0 red2 0 green1 1 green2 0 blue1 0 blue2 0
> x 0 y 15 red1 1 red2 0 green1 0 green2 0 blue1 0 blue2 0
>
>
> SInce we already have color-tolerance check present, there is no need of exact color value check.
> Also, made the frame undecorated and remove unneeded library being built.
> Several iterations of the test passed in the same system (where it used to fail 4/10) along with other platforms (link in JBS)
Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
Reduce color tolerance
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8380/files
- new: https://git.openjdk.java.net/jdk/pull/8380/files/c48274ad..a04c742b
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8380&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8380&range=00-01
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.java.net/jdk/pull/8380.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/8380/head:pull/8380
PR: https://git.openjdk.java.net/jdk/pull/8380
More information about the client-libs-dev
mailing list