RFR: 8284888 : [macos] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java failed with "NimbusLookAndFeel] : ERROR: icon and imageIcon not same."

[Phil Race]

On Wed, 4 May 2022 11:00:43 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> > This is occurring only on the M1 imac where despite having the right profile we see "off by 1/255" errors sometimes. So why do we need a color tolerance of 25 ? Why isn't it 1 ?
> 
> It was there from start so did not tinker although I tested with tolerance of 10 (which is the default tolerance used in other tests) which passed. Anyway, I have changed it to 1 which also passed in the intended system and all other platforms (CI job link in JBS)

Yes .. I went back and looked at the thread started here : https://mail.openjdk.java.net/pipermail/swing-dev/2016-January/005286.html
and it was in the first webrev and no one ever questioned why it was needed ..

perhaps some shadow effects were touching on the icon which is near the edge of the top-level window
but that could be cured easily in this test which is for JInternalFrame .. if it were actually an issue ..

-------------

PR: https://git.openjdk.java.net/jdk/pull/8380