RFR: 8286269: [java.desktop] Use newer instanceof language feature wherever possible

Julian Waters jwaters at openjdk.java.net
Fri May 6 04:06:48 UTC 2022


On Sat, 8 Jan 2022 18:13:45 GMT, SWinxy <duke at openjdk.java.net> wrote:

> The old java.desktop package needs dusting off. It hasn't been kept up to pace with the Java language, but it should. The purpose of this PR is to replace most or all `instanceof` checks with the new `instanceof` with a variable. Some methods that used `instanceof` were also reworked alongside the change (such as `.equals()`) if they were small and they could be clearer.
> There should be no actual change in outcomes from this PR. I have triple checked my work. Some cases are kinda 'wut?'.
> This is also a large change. When pattern matching for switch arrives, many methods can be reworked to take advantage of it (when it comes.. eventually ;w;).

You do need to become a registered Author to properly help new contributors though, but the requirement is only that you have 2 accepted PRs in the codebase. With the 4 PRs you already have, you should be able to get to Author in no time if all 4 get through :)

-------------

PR: https://git.openjdk.java.net/jdk/pull/7000



More information about the client-libs-dev mailing list