RFR: 8286271: [java.desktop] Replace ternary operators with java.lang.Math min/max

Phil Race prr at openjdk.java.net
Fri May 6 17:28:59 UTC 2022


On Sat, 15 Jan 2022 04:23:33 GMT, SWinxy <duke at openjdk.java.net> wrote:

> Delete `sun.java2d.marlin.FloatMath` class in favor of methods in `java.lang.Math`. The methods in `Math.java` are intrinsics and can gain from significant speedups. Hand-written min/max operations are also replaced with calls. 5 uses of `ceil` and 2 uses of `floor` were replaced.
> This should not cause any rendering differences from the different algorithms being used, as they theoretically will end up at the same outcomes.

I would like to  caution that in a previous bug fix where this form was replaced it was determined not to be 100% compatible

https://mail.openjdk.java.net/pipermail/client-libs-dev/2021-December/001694.html

In short, this is pointless churn and I reject this PR.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7097



More information about the client-libs-dev mailing list