RFR: 8284888 : [macos] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java failed with "NimbusLookAndFeel] : ERROR: icon and imageIcon not same." [v5]

[Phil Race]

On Thu, 5 May 2022 09:16:04 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Test used to fail in specific CI macos M1 system owing to miniscule color difference 
>> 
>> 
>> x 0 y 0 red1 171 red2 171 green1 174 green2 175 blue1 184 blue2 184
>> x 0 y 1 red1 172 red2 173 green1 177 green2 177 blue1 185 blue2 185
>> x 0 y 2 red1 173 red2 174 green1 177 green2 178 blue1 187 blue2 187
>> x 0 y 6 red1 0 red2 0 green1 1 green2 0 blue1 0 blue2 0
>> x 0 y 15 red1 1 red2 0 green1 0 green2 0 blue1 0 blue2 0
>> 
>> 
>> SInce we already have color-tolerance check present, there is no need of exact color value check.
>> Also, made the frame undecorated and remove unneeded library being built. 
>> Several iterations of the test passed in the same system (where it used to fail 4/10) along with other platforms (link in JBS)
>
> Prasanta Sadhukhan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
> 
>  - Remove from PL
>  - Merge branch 'master' of https://git.openjdk.java.net/jdk into JDK-8284888
>  - Modify icon capture area
>  - Modify icon capture area
>  - Reduce color tolerance
>  - Fix

I still think it is possible to enhance this by deliberating drawing the icons in different colors and expecting to see the rendered colours be the only difference and that they are in the same place in both cases .. but maybe what you have here is enough for now.

-------------

Marked as reviewed by prr (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8380