RFR: JDK-8255439: System Tray icons get corrupted when windows scaling changes [v3]
Kevin Rushforth
kcr at openjdk.java.net
Mon May 9 19:01:47 UTC 2022
On Sun, 8 May 2022 19:36:33 GMT, Harshitha Onkar <duke at openjdk.java.net> wrote:
>> In Windows, when desktop scaling is changed the tray icons was distorted/blurred a bit each time scaling changes.
>>
>> With the proposed fix, the tray icon scales according to on-the-fly DPI scale settings. A test case has been added which adds a MRI icon to system tray, to observe the icon scaling when DPI is changed. Since the scale cannot be programmatically changed (for dynamic on-the-fly scale changes), I have used a manual test case to test this scenario.
>>
>> When DPI changes usually two messages are sent by windows -
>>
>> - [WM_DPICHANGED](https://docs.microsoft.com/en-us/windows/win32/hidpi/wm-dpichanged)
>> - [WMPOSCHANGING](https://docs.microsoft.com/en-us/windows/win32/winmsg/wm-windowposchanging)
>>
>> I'm triggering an update on tray icons on receiving WMPOSCHANGING msg through the Tray icon's Window Procedure. Triggering an update on WM_DPICHANGED was still causing the icons to be distorted, hence WMPOSCHANGING is being used as the message to trigger the update.
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>
> formatting changes
Thanks for the additional comments. As far as I'm concerned, the only remaining question is the fact that the manual test doesn't exit for me when run from the command line.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8441
More information about the client-libs-dev
mailing list