RFR: JDK-8255439: System Tray icons get corrupted when windows scaling changes [v3]
Kevin Rushforth
kcr at openjdk.java.net
Mon May 9 21:59:49 UTC 2022
On Mon, 9 May 2022 21:02:11 GMT, Phil Race <prr at openjdk.org> wrote:
>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>>
>> formatting changes
>
> test/jdk/java/awt/TrayIcon/TrayIconScalingTest.java line 99:
>
>> 97: exitItem.addActionListener(e -> {
>> 98: tray.remove(icon);
>> 99: System.exit(0);
>
> Even if it is manual etc, we don't call System.exit() in jtreg tests .. we just shut down all the windows and dispose them so there is nothing to keep the main thread from exiting.
> If this is called, I don't know why Kevin didn't see the app exit.
> I suspect it cannot have been and he exited via some other path which left windows in existence which meant the toolkit thread didn't exit.
The `actionListener` is only called if you right click on the tray icon and select the Exit option. I didn't do that, so it never got here. Maybe the "Exit" button in the icon should be turned into a no-op, since you want the tester to press Pass or Fail to exit?
I think Alexey may have pointed out the problem with the test not exiting: it doesn't dispose the tray icon. That needs to be confirmed.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8441
More information about the client-libs-dev
mailing list