Integrated: JDK-8285730: unify _WIN32_WINNT settings

Matthias Baesken mbaesken at openjdk.java.net
Tue May 10 06:48:40 UTC 2022


On Wed, 27 Apr 2022 14:57:41 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> Currently we set _WIN32_WINNT at various places in the codebase; this is used to target a minimum Windows version we want to support. See also for more detailled information :
> https://docs.microsoft.com/en-us/windows/win32/winprog/using-the-windows-headers?redirectedfrom=MSDN#setting-winver-or-_win32_winnt
> Macros for Conditional Declarations
> "Certain functions that depend on a particular version of Windows are declared using conditional code. This enables you to use the compiler to detect whether your application uses functions that are not supported on its target version(s) of Windows."
> 
> However currently we have quite a lot of differing settings of _WIN32_WINNT in the codebase ; setting _WIN32_WINNT to 0x0601 (Windows 7) where possible would make sense because we have this setting already at   java_props_md.c  (so targeting older Windows versions at other places is most likely not useful).

This pull request has now been integrated.

Changeset: 4fd79a6a
Author:    Matthias Baesken <mbaesken at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/4fd79a6ad2683e4863bd4e311cb01cbc30ebf57f
Stats:     33 lines in 7 files changed: 2 ins; 25 del; 6 mod

8285730: unify _WIN32_WINNT settings

Reviewed-by: dholmes, erikj, ihse, prr, alanb

-------------

PR: https://git.openjdk.java.net/jdk/pull/8428



More information about the client-libs-dev mailing list