RFR: JDK-8282772: JButton text set as HTML content has unwanted padding [v3]

DamonGuy duke at openjdk.java.net
Tue May 10 18:05:40 UTC 2022


On Tue, 10 May 2022 06:29:47 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> DamonGuy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixed test summary. Added check for JButton.
>
> test/jdk/javax/swing/JButton/HtmlButtonImageTest/HtmlButtonImageTest.java line 116:
> 
>> 114:                 ImageIO.write(image, "png",
>> 115:                         new File(testDir + "/fail_image.png"));
>> 116:                 throw new RuntimeException("HTML image not centered in button");
> 
> overall looks ok. Only thing is during failure, it does not show for which L&F the test is failing since you are iterating for all L&Fs.

Sure, this can be changed. I can instead iterate through all L&F's and track all failing L&F's in a buffer to be displayed in the runtime exception in the end. How should the images be handled? Should I just generate X images where X is the number of failed L&F's?

-------------

PR: https://git.openjdk.java.net/jdk/pull/8407



More information about the client-libs-dev mailing list