Integrated: JDK-8282772: JButton text set as HTML content has unwanted padding

DamonGuy duke at openjdk.java.net
Wed May 11 23:32:38 UTC 2022


On Tue, 26 Apr 2022 19:42:05 GMT, DamonGuy <duke at openjdk.java.net> wrote:

> The insets for buttons were incorrect for L&Fs except for Aqua when the text is set to HTML. This was fixed in Aqua by adding a conditional to check for the BasicHTML property key in the button component. This same logic can be used to fix Metal & Motif L&Fs in BasicButtonUI, but Nimbus is not fixed by this. Nimbus gets its default values from a skin.laf file, and when the defaults here are set to have left & right insets to 0 for ButtonUI, the issue is fixed. I also tested for non-HTML text after the changes, and the changes do not affect normal text.
> 
> The HtmlButtonImageTest has been changed to cycle through all L&Fs available on a device.

This pull request has now been integrated.

Changeset: ccbe8faa
Author:    Damon Nguyen <damon.nguyen at oracle.com>
Committer: Phil Race <prr at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/ccbe8faa00b85a71ba84115c3321e20b661213c5
Stats:     118 lines in 3 files changed: 82 ins; 7 del; 29 mod

8282772: JButton text set as HTML content has unwanted padding

Reviewed-by: prr, psadhukhan

-------------

PR: https://git.openjdk.java.net/jdk/pull/8407



More information about the client-libs-dev mailing list