RFR: JDK-8255439: System Tray icons get corrupted when windows scaling changes [v8]

Harshitha Onkar duke at openjdk.java.net
Fri May 13 19:17:00 UTC 2022


On Fri, 13 May 2022 18:07:02 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:
>> 
>>  - Merge branch 'master' into WinTrayIcon
>>  - reverted SystemTray changes
>>  - new changes - trayicon update triggered in WmTaskbarCreated
>>  - trayicon update triggered on taskbar reload
>>  - test case exit issue fix
>>  - formatting changes
>>  - resized instruction window and formatted line lengths
>>  - removed whitespaces error due to CRLF
>>  - removed whitespace error
>>  - added manual to test case
>>  - ... and 1 more: https://git.openjdk.java.net/jdk/compare/8429be8e...60391f28
>
> src/java.desktop/share/classes/java/awt/TrayIcon.java line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2005, 2022, Oracle and/or its affiliates. All rights reserved.
> 
> You can revert this file, since the only remaining changes are this copyright year and import statements, which are relating to your fix.

@kevinrushforth Thank you for your suggestions . Will revert the files TrayIcon.java and WTrayIconPeer.java as suggested.

> test/jdk/java/awt/TrayIcon/TrayIconScalingTest.java line 129:
> 
>> 127:     }
>> 128: }
>> 129: 
> 
> Minor: there is an extra blank line here.

> One more thing to look at is that there is a failure in the GitHub Action run for the Windows x64 debug build that looks related to your changes. Make sure that you do a CI build with your latest changes.

Yes, there might have been a mix-up with variable name when I pushed the changes. Currently working on it. I'll check the CI build status before pushing the next update. Thank you!

-------------

PR: https://git.openjdk.java.net/jdk/pull/8441



More information about the client-libs-dev mailing list