RFR: 8257810: Only First page are printed in JTable.scrollRectToVisible [v11]

Alexey Ivanov aivanov at openjdk.java.net
Fri May 13 19:34:57 UTC 2022


On Thu, 12 May 2022 04:05:48 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> test/jdk/javax/swing/JTable/PrintAllPagesTest.java line 80:
>> 
>>> 78:             try {
>>> 79:                 if (!table.print()) {
>>> 80:                     throw new RuntimeException("Printing cancelled");
>> 
>> When run outside of jtreg, this exception doesn't stop the test. In jtreg, it does.
>> 
>> So it works as expected when run in jtreg but it could be confusing if run as a stand-alone test.
>
> I amnot sure if anyone will try to run it outside jtreg as it has dependancy on jtreg helper class PassFailJFrame
> but anyway I have tried to address the concern.

I usually do.

In fact, your change doesn't resolve the problem. However, you've made it easier to resolve now. The thing is disposing of frames is hidden inside `awaitAndCheck`.

Anyway I see no reason to keep this PR open. The problem can be addressed later if required.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8141



More information about the client-libs-dev mailing list