RFR: 8286270: [java.desktop] Replace color search in XColors with a switch statement [v2]

SWinxy duke at openjdk.java.net
Sat May 14 17:37:46 UTC 2022


On Sun, 8 May 2022 02:44:16 GMT, Phil Race <prr at openjdk.org> wrote:

>> SWinxy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove @author tags per request
>
> src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/XColors.java line 35:
> 
>> 33:  * @author Shannon Hickey
>> 34:  * @author SWinxy
>> 35:  */
> 
> You aren't the author, you are changing the file, and if we go anywhere near @author tags it is to remove them, not add them. Plus "Swinxy" is not very professional

Done. I wasn't aware of the intent to get rid of the `@author` tags, but it's very valid. They've been removed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7096



More information about the client-libs-dev mailing list