RFR: 8233477 [Win LAF]The tooltip doesn't display correctly in Win LAF [v4]

Tejesh R duke at openjdk.java.net
Mon May 16 09:09:02 UTC 2022


On Fri, 13 May 2022 22:39:55 GMT, Phil Race <prr at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removed the test from open, updated in closed
>
> I find it very strange that https://bugs.openjdk.java.net/browse/JDK-5047379 was fixed in 2005
> and the bug report there says 
>> This fix only affects tooltips. It can be tested on any platform as it is platform independent.
> 
> And by platforms it really means for the default L&F which is Metal on Windows .. 
> 
> So I think the reason it took 14 years for anyone to notice it wasn't behaving the same on Windows L&F
> is that it wasn't designed for the Windows L&F
> 
> Which begs two questions, 
> 1) why was someone testing it on a non-default L&F .. "we run all tests on all L&Fs"  isn't really something you should do without careful thought
> 2) Does this mean it is actually a Metal "special" behaviour .. do Windows NATIVE apps display mnemonics on tool tips ?
> And since per the eval of 5047379
>> the only time we'll show an accelerator key in the tooltip is if someone has added a WHEN_IN_FOCUSED_WINDOW binding to the component's InputMap.
> 
> Perhaps no one should be caring about this ?
> 
> Maybe we just update the test to hardwire Metal and move on ? That'll mean the test will always pass no matter what L&F SQE specify as the default ..

Yeah, agree with you @prrace. If it is meant for Metal alone, then let me update the test case by setting Metal look and feel in the code.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8496



More information about the client-libs-dev mailing list