RFR: JDK-8255439: System Tray icons get corrupted when windows scaling changes [v9]
Phil Race
prr at openjdk.java.net
Mon May 16 20:56:46 UTC 2022
On Mon, 16 May 2022 20:19:55 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>>
>> added ExceptionClear, fixed CI debug build issue
>
> src/java.desktop/windows/native/libawt/windows/awt_TrayIcon.cpp line 73:
>
>> 71: jfieldID AwtTrayIcon::idID;
>> 72: jfieldID AwtTrayIcon::actionCommandID;
>> 73: jmethodID AwtTrayIcon::updateImageDpiID;
>
> I'd rather drop 'Dpi' from the name because the name of the Java method is `updateImage`.
>
> If you prefer, the C++ class method could also be changed to `UpdateImage`, dropping 'DPI'.
yes, that's a good point on the naming
-------------
PR: https://git.openjdk.java.net/jdk/pull/8441
More information about the client-libs-dev
mailing list