RFR: 8285687 : Remove jtreg tag manual=yesno for ava/awt/print/PrinterJob/PageRangesDlgTest.java [v5]

[Alexey Ivanov]

On Fri, 29 Apr 2022 20:37:30 GMT, lawrence.andrews <duke at openjdk.java.net> wrote:

>> 1) Fixed Parser error by removing  yesno from @run main/manual=yesno 
>> 2) Used PassFaileJFrame to show the test instruction to the user instead of printing the test instruction on the console or jtreg log file. 
>> 3) If printer is not configured then mark the test as passed.
>> 
>> @shurymury 
>> @aivanov-jdk
>
> lawrence.andrews has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Added jtreg.SkippedException
>  - Added jtreg.SkippedException

Can't we use existing `jtreg.SkippedException` in `test/lib`?

Modify PageRangesDlgTest:


diff --git a/test/jdk/java/awt/print/PrinterJob/PageRangesDlgTest.java b/test/jdk/java/awt/print/Pri
nterJob/PageRangesDlgTest.java
index 77be99107d1..0d8ce30057a 100644
--- a/test/jdk/java/awt/print/PrinterJob/PageRangesDlgTest.java
+++ b/test/jdk/java/awt/print/PrinterJob/PageRangesDlgTest.java
@@ -37,9 +37,9 @@ import jtreg.SkippedException;
  * @bug 8061267
  * @key printer
  * @library /java/awt/regtesthelpers
- * @library /java/awt/jtreg
+ * @library /test/lib
  * @build PassFailJFrame
- * @build SkippedException
+ * @build jtreg.SkippedException
  * @summary The specified page range should be displayed in the dialog
  * @run main/manual PageRangesDlgTest
  */


The test can't pass when the native Print dialog is displayed: `aset` should be passed to it:

@@ -58,7 +58,7 @@ public class PageRangesDlgTest implements Printable {
         job = PrinterJob.getPrinterJob();
         job.setPrintable(new PageRangesDlgTest());
         aset.add(DialogTypeSelection.NATIVE);
-        if (job.printDialog()) {
+        if (job.printDialog(aset)) {
             job.print();
         }
     }

-------------

PR: https://git.openjdk.java.net/jdk/pull/8412