RFR: 8286270: [java.desktop] Replace color search in XColors with a switch statement [v3]
SWinxy
duke at openjdk.java.net
Fri May 20 00:53:27 UTC 2022
> The current implementation creates ~750 new objects on load, and uses a binary array search with a Comparable implementation. This implementation is probably bad. Instead, we can use the enhanced switch feature to possibly save time, resources, and code size. The new implementation means that the array doesn't have to be sorted alphanumerically necessarily, and it creates the colors on demand.
SWinxy has updated the pull request incrementally with one additional commit since the last revision:
Accidental mergers.
I created a quick check to see if any other colors were different (only these three). For some odd reason "yellowgreen" and "yellow green" are different.
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7096/files
- new: https://git.openjdk.java.net/jdk/pull/7096/files/79f3ddf7..32640e43
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7096&range=02
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7096&range=01-02
Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod
Patch: https://git.openjdk.java.net/jdk/pull/7096.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/7096/head:pull/7096
PR: https://git.openjdk.java.net/jdk/pull/7096
More information about the client-libs-dev
mailing list