RFR: 8286172: Create an automated test for JDK-4516019 [v2]

[Alisen Chung]

On Tue, 17 May 2022 12:36:04 GMT, Srinivas Mandalika <smandalika at openjdk.org> wrote:

>> Create an automated test for [JDK-4516019](https://bugs.openjdk.java.net/browse/JDK-4516019)
>> 
>> Clicking on the increment/decrement buttons of the spinner does not install focus on the spinner or one of its focusable children.
>> 
>> The test validates the same.
>> 
>> This review is for migrating tests from a closed test suite to open.
>> 
>> Testing:
>> The test ran successfully on Mach5 with multiple runs (30) on windows-x64, linux-x64 and macos-x64.
>
> Srinivas Mandalika has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Review comments fixed: Fixed file path, removed redundant sleep call etc.
>  - Review comments fixed: Removed file under the 'bug id' folder structure

Changes requested by achung (Author).

test/jdk/javax/swing/JSpinner/JSpinnerFocusTest.java line 69:

> 67:         try {
> 68:             SwingUtilities.invokeAndWait(() -> createGUI());
> 69:             Thread.sleep(1000);

Would it be better to make robot a global variable and use Robot.waitForIdle() here? Sleeping might slow down the test unnecessarily

test/jdk/javax/swing/JSpinner/JSpinnerFocusTest.java line 71:

> 69:             Thread.sleep(1000);
> 70:             runTest();
> 71:             Thread.sleep(1000);

same here

-------------

PR: https://git.openjdk.java.net/jdk/pull/8546