RFR: 8286620: Create regression test for verifying setMargin() of JRadioButton [v2]

Tejesh R duke at openjdk.java.net
Wed May 25 12:21:55 UTC 2022


On Tue, 24 May 2022 10:42:34 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Tejesh R has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
>> 
>>  - Updated based on review comments
>>  - Merge branch 'master' of https://git.openjdk.java.net/jdk into branch_8286620
>>  - Moving bug4380543.java from closed to open
>>  - Merge branch 'master' of github.com:TejeshR13/jdk
>>  - Merge branch 'openjdk:master' into master
>>  - Merge remote-tracking branch 'upstream/master'
>>  - Merge remote-tracking branch 'upstream/master'
>>  - Merge branch 'master' of github.com:TejeshR13/jdk
>>  - Initial Commit.
>
> test/jdk/javax/swing/JRadioButton/bug4380543.java line 143:
> 
>> 141:     {
>> 142:         disposeUI();
>> 143:         if (res.toString() == "false")
> 
> This looks weird. Why can't you use `res.get()`? It returns a `Boolean` object which can be used directly in an if-condition.

Updated as per the review comments @aivanov-jdk .

-------------

PR: https://git.openjdk.java.net/jdk/pull/8721



More information about the client-libs-dev mailing list