RFR: 6201035: Document NPE for passing null insets to constructors and methods of several javax.swing.border.* classes [v7]

Alexey Ivanov aivanov at openjdk.org
Thu Nov 3 11:21:20 UTC 2022


On Thu, 3 Nov 2022 03:27:29 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> The behavior of MatteBorder constructors taking Insets object as a parameter is undocumented. It would throw NPE if null object is passed to it, which should be documented in the spec.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   AbstractBorder fix

Marked as reviewed by aivanov (Reviewer).

> Before I can approve this PR, I would like to see the javadoc for border classes (those that are modified) updated so that all of them use _“Reinitializes”_ as the first word in the description instead of _“Reinitialize”_, which aligns with [the javadoc style guide](https://www.oracle.com/technical-resources/articles/java/javadoc-tool.html#styleguide):
> 
> > **Use 3rd person (descriptive) not 2nd person (prescriptive).**
> > The description is in 3rd person declarative rather than 2nd person imperative.
> > Gets the label. _(preferred)_
> > Get the label. (avoid)

Per the comment in JBS, addressing this is deferred to a separate issue… However, I still think it would've been more efficient to handle it here. Anyway, it's approved now.

-------------

PR: https://git.openjdk.org/jdk/pull/10740



More information about the client-libs-dev mailing list