RFR: 6972078: Can not select single directory with GTKLookAndFeel [v4]

Abhishek Kumar duke at openjdk.org
Fri Nov 4 10:04:44 UTC 2022


On Fri, 4 Nov 2022 06:29:31 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Subtest added for file selection mode
>
> test/jdk/com/sun/java/swing/plaf/gtk/TestFileChooserSingleDirectorySelection.java line 113:
> 
>> 111:             clickMouse(frameLocation, 0, frameHeight, 230);
>> 112:             clickMouse(btnLocation, btnWidth, btnHeight, 0);
>> 113:             checkResult(laf);
> 
> I guess you can optimise by a helper method for this repeated code passing the offset value as paramter.
> 
> Also, did you check [JDK-4912623](https://bugs.openjdk.org/browse/JDK-4912623) as mentioned?

Added a helper method for the repeated code.

I tried to reproduce the [JDK-4912623](https://bugs.openjdk.org/browse/JDK-4912623) bug. SwingSet2 JFileChooser demo behaves as it is mentioned in the bug description but in Gedit I didn't find separate folder and files list.

-------------

PR: https://git.openjdk.org/jdk/pull/10866



More information about the client-libs-dev mailing list