RFR: 8296335 : Fix accessibility manual test instruction [v3]

Alexey Ivanov aivanov at openjdk.org
Fri Nov 4 22:31:19 UTC 2022


On Fri, 4 Nov 2022 21:37:47 GMT, lawrence.andrews <duke at openjdk.org> wrote:

>> Fixed test instruction that helps the manual tester to perform actions
>> 
>> @shurymury
>
> lawrence.andrews has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add a blank line

Changes requested by aivanov (Reviewer).

test/jdk/javax/accessibility/manual/ButtonDemo.html line 81:

> 79: </html>
> 80: 
> 81: 

This is not necessary: two blank lines also cause problems.

test/jdk/javax/accessibility/manual/OptionPaneDemo.html line 78:

> 76: </html>
> 77: 
> 78: 

Ah, it looks the last line wasn't considered blank because it contained trailing spaces. There should be no trailing spaces, there should be only one blank line in the end of the file. In this case, the HTML file should have 77 lines.

test/jdk/javax/accessibility/manual/TableDemo.html line 81:

> 79: </html>
> 80: 
> 81: 

The same as above, trailing white-space caused GitHub to indicate the missing blank line at the end of the file.

test/jdk/javax/accessibility/manual/TreeDemo.html line 67:

> 65: </html>
> 66: 
> 67: 

There should be only one, not two.

-------------

PR: https://git.openjdk.org/jdk/pull/10996



More information about the client-libs-dev mailing list