RFR: 6972078: Can not select single directory with GTKLookAndFeel [v5]

Andrey Turbanov aturbanov at openjdk.org
Sun Nov 6 16:19:35 UTC 2022


On Fri, 4 Nov 2022 09:56:36 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> While using a JFileChooser with the file selection mode FILES_AND_DIRECTORIES and multiSelection enabled, it is impossible to select a single directory in GTK LAF.
>> 
>> The condition check has been modified when multiselection is enabled and user has selected single directory.
>> After the fix the behavior of JFileChooser is similar to other LAFs.
>> 
>> An automatic test case `test/jdk/com/sun/java/swing/plaf/gtk/TestFileChooserSingleDirectorySelection.java` is implemented and checked in CI pipeline. Link is attached in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comment fix

test/jdk/com/sun/java/swing/plaf/gtk/TestFileChooserSingleDirectorySelection.java line 115:

> 113: 
> 114:     private static void checkDirectoriesOnlyTest(UIManager.LookAndFeelInfo laf)
> 115:             throws Exception  {

Suggestion:

            throws Exception {

test/jdk/com/sun/java/swing/plaf/gtk/TestFileChooserSingleDirectorySelection.java line 135:

> 133: 
> 134:     private static void checkFilesAndDirectoriesTest(UIManager.LookAndFeelInfo laf)
> 135:             throws Exception  {

Suggestion:

            throws Exception {

-------------

PR: https://git.openjdk.org/jdk/pull/10866



More information about the client-libs-dev mailing list