RFR: 8296496: Overzealous check in sizecalc.h prevents large memory allocation [v2]

Alexander Zuev kizune at openjdk.org
Tue Nov 8 23:25:40 UTC 2022


> Removed the additional multiplication overflow detection.
> Instead cast all the parameters to type_t just the way they are treated in the existing size check macro. 
> This way there is no possibility to accidentally provide parameters that will pass the size check macro while being cast to size_t there but then due to the missing cast cause the wrong size passed the actual allocation function.
> Since this checking macro was used in couple of different places all of them needs to be updated in the similar way.

Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:

  Streamlining structure allocation

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/11030/files
  - new: https://git.openjdk.org/jdk/pull/11030/files/3a3e7769..ee223fc9

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=11030&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11030&range=00-01

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/11030.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/11030/head:pull/11030

PR: https://git.openjdk.org/jdk/pull/11030



More information about the client-libs-dev mailing list