RFR: 8296275: Write a test to verify setAccelerator method of JMenuItem. [v2]

Srinivas Mandalika smandalika at openjdk.org
Wed Nov 9 06:15:29 UTC 2022


On Wed, 9 Nov 2022 05:40:46 GMT, Naveen Narayanan <duke at openjdk.org> wrote:

>> Colocate JMenuItemSetAcceleratorTest to a regression test.
>> 
>> This testcase will
>> 1) Verify setAccelerator method of JMenuitem.
>> 2) Check that the selection of a menu item in the menu bar will generate action by a key combination of META+M.
>> 
>> Testing:
>> Tested using Mach5(20 times per platform) in Mac OS, Linux and Windows and got all pass.
>
> Naveen Narayanan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8296275: Review comments fixed.

test/jdk/java/awt/Desktop/JMenuItemSetAcceleratorTest.java line 77:

> 75:                 || !Desktop.getDesktop().isSupported(Action.APP_MENU_BAR)) {
> 76:                 System.out.println(
> 77:                     "Test passed as Desktop or Action.APP_MENU_BAR is not supported.");

More accurate to have this as: 
"Test skipped as Desktop or Action.APP_MENU_BAR is not supported."

-------------

PR: https://git.openjdk.org/jdk/pull/11035



More information about the client-libs-dev mailing list