RFR: 8296222: SwingEventMonitor - installListeners(Component , int ) - CELLEDITOR - bug
Andy Goryachev
angorya at openjdk.org
Thu Nov 10 16:32:30 UTC 2022
On Thu, 10 Nov 2022 08:01:38 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:
> It seems there was a typo inside function `installListeners(Component, int)` and `removeListeners(Component)` on case EventID.CELLEDITOR.
>
> Changed the string from "getCellEditorMethod" to "getCellEditor" in `protected void installListeners(Component c, int eventID)` and `protected void removeListeners(Component c)` methods.
>
> Didn't add any test case.
Marked as reviewed by angorya (no project role).
src/jdk.accessibility/share/classes/com/sun/java/accessibility/util/SwingEventMonitor.java line 990:
> 988: try {
> 989: getCellEditorMethod = c.getClass().getMethod(
> 990: "getCellEditor", nullClass);
1. why would they use reflection in the first place?
2. wouldn't these code paths be covered by (failing) accessibility unit tests?
-------------
PR: https://git.openjdk.org/jdk/pull/11082
More information about the client-libs-dev
mailing list