RFR: 8296812: sprintf is deprecated in Xcode 14 [v4]

[Lutz Schmidt]

On Mon, 14 Nov 2022 05:32:20 GMT, Xue-Lei Andrew Fan <xuelei at openjdk.org> wrote:

>> Hi,
>> 
>> May I have this update reviewed?
>> 
>> The sprintf is deprecated in Xcode 14 because of security concerns, and the use of it causing building failure.  The build could pass if warnings are disabled for codes that use sprintf method.  For the long run, the sprintf could be replaced with snprintf.  This patch is trying to check if snprintf could be used.
>> 
>> Thanks,
>> Xuelei
>
> Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   include missing os head file

src/hotspot/share/adlc/output_c.cpp line 536:

> 534:     int printed = snprintf(args, 37, "0x%x, 0x%x, %u",
> 535:       resources_used, resources_used_exclusively, element_count);
> 536:     assert(printed <= 36, "overflow");

if snprintf works correctly (we rely on that), this assert will never fire.

-------------

PR: https://git.openjdk.org/jdk/pull/11115