RFR: 8157173: [macosx] java/awt/Robot/ModifierRobotKey/ModifierRobotKeyTest.java fails [v2]

Phil Race prr at openjdk.org
Tue Nov 15 18:29:12 UTC 2022


On Mon, 14 Nov 2022 14:38:38 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> This test currently passing as it is on all platforms, but it was problemlisted with ["Problem List some tests that leave windows open on the desktop" reason](https://github.com/openjdk/jdk/commit/fd8df3adf13f5df8f5f95482b8e0a70bc519f39f)
>> 
>> So this test is cleaned up and stabilized.
>> 
>> CI testing looks good.
>
> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Addressing review comments

Regarding the test stabilization and functional changes:
* wrapped keyRelease, frame.dispose calls with finally
* increased delay after frame appearance
* increased AutoDelay

OK .. these seem worthwhile.

-------------

Marked as reviewed by prr (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11128



More information about the client-libs-dev mailing list